-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix failling tests #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix failling tests #1812
Conversation
|
let's try a simple fix first, because I can't yet explain myself why the tests are failing. May be there is a concurrency issue here, thus I replaced an array with an btw, I can't replay to the original message you did, because github does not show messages under commits anymore for me, it just shows that it tries to load them, but never does, so if you do not mind, let's keep the discussion here. |
|
@wind57 unfortunately it still failed. Below are the logs from |
|
I have a hint of why they fail, will work on a test fix soon |
No description provided.